Skip to content

feat(tracemetrics)!: Update types #17907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

feat(tracemetrics)!: Update types #17907

wants to merge 6 commits into from
+11 −12

Conversation

chargome
Copy link
Member

@chargome chargome commented Oct 10, 2025 •
edited
Loading

  • Fixing some of the types according to the specs.

@chargome chargome self-assigned this Oct 10, 2025
@chargome chargome changed the title fix(tracemetrics): Update types feat(tracemetrics)!: Update types Oct 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 10, 2025 •
edited
Loading

size-limit report 📦

Path Size % Change Change
@sentry/browser 24.63 kB -0.06% -13 B 🔽
@sentry/browser - with treeshaking flags 23.13 kB -0.06% -13 B 🔽
@sentry/browser (incl. Tracing) 40.98 kB -0.03% -12 B 🔽
@sentry/browser (incl. Tracing, Replay) 79.28 kB -0.02% -10 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 68.96 kB -0.03% -16 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas) 83.99 kB -0.02% -10 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback) 96.15 kB -0.02% -10 B 🔽
@sentry/browser (incl. Feedback) 41.31 kB -0.03% -12 B 🔽
@sentry/browser (incl. sendFeedback) 29.28 kB -0.05% -12 B 🔽
@sentry/browser (incl. FeedbackAsync) 34.24 kB -0.05% -14 B 🔽
@sentry/react 26.34 kB -0.05% -11 B 🔽
@sentry/react (incl. Tracing) 42.98 kB -0.03% -11 B 🔽
@sentry/vue 29.12 kB -0.05% -12 B 🔽
@sentry/vue (incl. Tracing) 42.78 kB -0.04% -13 B 🔽
@sentry/svelte 24.64 kB -0.06% -14 B 🔽
CDN Bundle 26.93 kB -0.04% -10 B 🔽
CDN Bundle (incl. Tracing) 41.64 kB -0.03% -9 B 🔽
CDN Bundle (incl. Tracing, Replay) 77.88 kB -0.02% -9 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) 83.34 kB -0.02% -9 B 🔽
CDN Bundle - uncompressed 78.91 kB -0.06% -41 B 🔽
CDN Bundle (incl. Tracing) - uncompressed 123.49 kB -0.04% -41 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed 238.5 kB -0.02% -41 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 251.26 kB -0.02% -41 B 🔽
@sentry/nextjs (client) 45.05 kB -0.03% -11 B 🔽
@sentry/sveltekit (client) 41.41 kB -0.03% -11 B 🔽
@sentry/node-core 50.77 kB -0.03% -12 B 🔽
@sentry/node 154.39 kB -0.01% -15 B 🔽
@sentry/node - without tracing 92.64 kB -0.02% -12 B 🔽
@sentry/aws-serverless 106.34 kB -0.01% -9 B 🔽

View base workflow run

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 10, 2025 •
edited
Loading

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,871 - 9,344 -5%
GET With Sentry 1,378 16% 1,412 -2%
GET With Sentry (error only) 6,125 69% 6,130 -0%
POST Baseline 1,208 - 1,211 -0%
POST With Sentry 533 44% 509 +5%
POST With Sentry (error only) 1,063 88% 1,069 -1%
MYSQL Baseline 3,313 - 3,221 +3%
MYSQL With Sentry 492 15% 370 +33%
MYSQL With Sentry (error only) 2,726 82% 2,625 +4%

View base workflow run

@chargome chargome requested review from AbhiPrasad and k-fish October 13, 2025 09:04
cursor[bot]

This comment was marked as outdated.

Sign in to view

AbhiPrasad
AbhiPrasad reviewed Oct 14, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad left review comments

@cursor cursor[bot] cursor[bot] left review comments

@k-fish k-fish Awaiting requested review from k-fish

At least 1 approving review is required to merge this pull request.

Assignees

@chargome chargome

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chargome @AbhiPrasad